Skip to content

Resolves kafbat/kafka-ui#90 Added contract profile, to only build API, local profile now builds frontend#669

Closed
KliminV wants to merge 10 commits intokafbat:mainfrom
KliminV:feature/refactor-maven-profiles
Closed

Resolves kafbat/kafka-ui#90 Added contract profile, to only build API, local profile now builds frontend#669
KliminV wants to merge 10 commits intokafbat:mainfrom
KliminV:feature/refactor-maven-profiles

Conversation

@KliminV
Copy link

@KliminV KliminV commented Nov 22, 2024 •
edited by Haarolean
Loading

Added contract profil, to only build API
Local profile now builds frontend

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resolves #90

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@KliminV
Added contract profile, to only build API.
d7ad473 
Local profile now builds frontend
@KliminV KliminV requested a review from a team as a code owner November 22, 2024 20:10
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/frontend Related to frontend changes status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 22, 2024
github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi KliminV! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@KliminV
Copy link
Author

KliminV commented Nov 22, 2024 •
edited
Loading

I think no unit tests are needed. However I would be happy to update documentation if needed
Also, can't link issue myself #90

@KliminV KliminV closed this Nov 23, 2024
@KliminV
resolves kafbat#90
6927e2b 
Moved parent modules section into profiles
Added default profile to build all modules.
UI now only runs with local / prod profiles, but skipped by default
@KliminV KliminV reopened this Nov 23, 2024
@KliminV
Copy link
Author

KliminV commented Nov 26, 2024

@Haarolean could you please take a look?

Haarolean
Haarolean requested changes Dec 2, 2024
View reviewed changes
@KliminV KliminV requested a review from a team as a code owner December 3, 2024 23:30
@Haarolean Haarolean self-requested a review February 28, 2025 02:44
@Haarolean
Copy link
Member

Haarolean commented Mar 8, 2025

hey @KliminV,
appreciate the effort on this! while this was open, we ended up migrating to gradle (#783), so this config is no longer needed.

in gradle, these things are now handled like this:

release = resolveBooleanProperty("release")
    includeFrontend = resolveBooleanProperty("include-frontend", release)
    buildDockerImages = resolveBooleanProperty("build-docker-images", release)
    runE2e = resolveBooleanProperty("run-e2e")
    e2eHeadlessOff = resolveBooleanProperty("e2e-headless-off")
    e2eSelenoidOff = resolveBooleanProperty("e2e-selenoid-off")

if you're up for it, would love to see you tackle another issue - here are a few that might be interesting:
good first issues

thanks again, and i'll make sure to review quicker next time! :)

@Haarolean Haarolean closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Awaiting requested review from Haarolean

Assignees

No one assigned

Labels

scope/frontend Related to frontend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor maven profiles

2 participants

@KliminV @Haarolean